fix: don't make keypool refill spam progress bars #5851
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Trivial bug:
keypoolrefill
internally updates the status of the progress bar each second.However it can happen that one second is not enough time to make significant progress and
static_cast<int>(dProgress) = 0
.Calling the function with
0
as progress opens a new progress bar and this led to problems like #5730What was done?
trivially make sure to update the progress only if the parameter is >0
How Has This Been Tested?
rpc does not spam anymore
Checklist:
Go over all the following points, and put an
x
in all the boxes that apply.